On Thu, May 03, 2007 at 09:00:48AM +1000, Rusty Russell wrote: >On Thu, 2007-05-03 at 03:33 +0800, WANG Cong wrote: >> Hi Rusty! >> >> I found you forgot to check the return value of copy_from_user, and >> here is the fix for drivers/lguest/interrupts_and_traps.c. >> >> Signed-off-by: WANG Cong <xiyou.wangcong@xxxxxxxxx> > >Hi Wang! > > Thanks for the patch. This omission (in several places) was >deliberate. We can't really do anything sensible if the user unmapped >the page. I assume you saw a gcc warning from this code? Yes. In fact, I got two warnings, another one is in drivers/lguest/hypercalls.c. If I understand you correctly, you mean we can do nothing useful to fix it? > > We could also use lgread() in these places which does this check and >kills the guest if something goes wrong. I'll check the benchmarks to >make sure the (slight) extra overhead doesn't cause a regression... > >Thanks! >Rusty. I have sent a mail which described the errors I got when comipling Documentation/lguest/lguest.c. But it seems that you didn't receive it (it didn't appear in lkml.org neither!). It is that, I have already made my .config as you suggested, but I still can't compile Documentation/lguest/lguest.c, errors are: lguest.c: In function 'add_to_bridge': lguest.c:779: error: 'SIOCBRADDIF' undeclared (first use in this function) lguest.c:779: error: (Each undeclared identifier is reported only once lguest.c:779: error: for each function it appears in.) Can you help me out? Thanks! _______________________________________________ Virtualization mailing list Virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linux-foundation.org/mailman/listinfo/virtualization
