Re: [PATCH] USB: mos7840: correct handling of CS5 setting

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Nov 08, 2013 at 10:52:34PM +0100, Colin Leitner wrote:
> This patch removes an erroneous check of CSIZE, which made it impossible to set
> CS5.
> 
> Compiles clean, but couldn't test against hardware.

The patch is obviously correct, but I've verified that CS5 actually
works using a MCS7820 as well.

> Signed-off-by: Colin Leitner <colin.leitner@xxxxxxxxx>

Tested-by: Johan Hovold <jhovold@xxxxxxxxx>
Cc: stable@xxxxxxxxxxxxxxx
Signed-off-by: Johan Hovold <jhovold@xxxxxxxxx>

Thanks,
Johan

> ---
>  drivers/usb/serial/mos7840.c |   32 ++++++++++++++++----------------
>  1 file changed, 16 insertions(+), 16 deletions(-)
> 
> diff --git a/drivers/usb/serial/mos7840.c b/drivers/usb/serial/mos7840.c
> index e5bdd98..a69da83 100644
> --- a/drivers/usb/serial/mos7840.c
> +++ b/drivers/usb/serial/mos7840.c
> @@ -1813,25 +1813,25 @@ static void mos7840_change_port_settings(struct tty_struct *tty,
>  	iflag = tty->termios.c_iflag;
> 
>  	/* Change the number of bits */
> -	if (cflag & CSIZE) {
> -		switch (cflag & CSIZE) {
> -		case CS5:
> -			lData = LCR_BITS_5;
> -			break;
> +	switch (cflag & CSIZE) {
> +	case CS5:
> +		lData = LCR_BITS_5;
> +		break;
> 
> -		case CS6:
> -			lData = LCR_BITS_6;
> -			break;
> +	case CS6:
> +		lData = LCR_BITS_6;
> +		break;
> 
> -		case CS7:
> -			lData = LCR_BITS_7;
> -			break;
> -		default:
> -		case CS8:
> -			lData = LCR_BITS_8;
> -			break;
> -		}
> +	case CS7:
> +		lData = LCR_BITS_7;
> +		break;
> +
> +	default:
> +	case CS8:
> +		lData = LCR_BITS_8;
> +		break;
>  	}
> +
>  	/* Change the Parity bit */
>  	if (cflag & PARENB) {
>  		if (cflag & PARODD) {
> -- 
> 1.7.10.4
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux