On Thu, Nov 07, 2013 at 08:26:58PM +0100, Colin Leitner wrote: > > Great, all looks good now. Thanks for fixing this. Did you check if > > there are even more (USB) serial drivers with similar problems (i.e. > > testing C_CSIZE(tty) in set_termios)? > > I just casually scanned through and, at least CSIZE, seems to be > handled pretty well by the ones with lots of IDs. I'll take the time > and test the Silabs driver (cp210x.c) as soon as I can get hold of > a converter. I have one of those here somewhere, but at least that part of the driver looks ok to me. Just did a quick grep: git grep -pW 'if.*CSIZE' and it turns out that at least the following two drivers are incorrectly testing for C_SIZE(tty) != 0: drivers/usb/serial/mos7840.c drivers/usb/serial/spcp8x5.c Care to fix them up as well? I have a mos7840 to test with. > The TI converter supports mark and space parity with the windows > drivers, but that might need an updated ti_3410.fw. I'll check that > out and contact TI whether it's OK to salvage the new firmware from > their latest drivers if that's really necessary. Sounds good. Thanks, Johan -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
