Hello.
On 08/14/2013 10:04 PM, Sebastian Andrzej Siewior wrote:
+USB
+~~~
+compatible: ti,musb-am33xx
+reg: offset and length "USB Controller Registers"
+reg-names: control
+
+This node contains the musb core:
+- compatible: "mg,musbmhdr"
"mg,musbmhdrc" you mean?
Yes.
Perhaps it's worth documenting the "mg" prefix in
Documentation/devicetree/bindings/vendor-prefixes.txt if it's official?
+- multipoint : Should be "1" indicating the musb controller supports
multipoint. This is a MUSB configuration-specific setting.
[...]
+- num-eps : Specifies the number of endpoints. This is also a
+ MUSB configuration-specific setting. Should be set to "16"
+- ram-bits : Specifies the ram address size. Should be set to "12"
+- port-mode : Should be "3" to represent OTG. "1" signifies HOST and "2"
+ represents PERIPHERAL.
The above props should probably be prefixed with "mg," being Mentor
Graphics specific.
This wasn't done in the other dts files but this does not make it
right. I fix it up.
Thanks.
+- power : Should be "250". This signifies the controller can supply
up to
+ 500mA when operating in host mode.
This one too.
Hmm. I'm not too happy with this beeing as defined by the USB
specification. Would you mind if I change it to mA instead?
I don't care much. I just wanted it prefixed.
+- phys: reference to the USB phy
+- dmas: specifies the dma channels
+- dma-names: specifies the names of the channels. Use "rxN" for receive
+ and "txN" for transmit endpoints. N specifies the endpoint number.
+
+The controller should have an "usb" alias numbered properly in the alias
+node.
+
+DMA
+~~~
+- compatible: ti,am3359-cppi41
"ti,cppi41" should follow I think.
I would go for ti,am3359-cppi41 because it has been tested on this
device. I wouldn't mind flipping 9 by an x.
No, wildcards are not allowed.
< The problem is that it is
not generic cppi41 because it needs that glue thingy
Glue thingy doesn't control or affect CPPI 4.1 controller in any way I
suspect.
and it is only
able to do USB transfers.
Who told you this? CPPI 4.1 is a generic packet oriented DMA controller.
The USB DMA registers do not belong to CPPI 4.1, and they control only how
CPPI FIFOs form the packets for CPPI 4.1 (it concatenates USB packets in
generic RNDIS mode)
So adding a trailing USB might be good
No, it's not good.
but the am335x has only one cppi41 engine which does USB (the network one
is cppi3 something).
What you think?
I didn't get the last passage, frankly speaking. Yes, I know CPPI 4.1 only
serves USB and is a part of a large, dual controller USB peripheral in AM335x
but at least it's not per MUSB controller...
WBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
