Re: Commit 09fc7d22b0 (usb: musb: fix incorrect usage of resource pointer) questions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello.

On 08/14/2013 01:33 AM, Felipe Balbi wrote:

    I have basically two questions on this change:

[...]

2) why you omitted am35x.c from this commit?

mistake

    Are you going to fix it, or should I?

    I'm just not sure how many resources there are with all these
hwmod complications...

tell me about it.

    I hoped you tell me. :-)

Kishon was going to send a patch which would allocate
and copy those resources dynamically based on pdev->num_resources.

    That would be undesirable in the light of my WIP patch making MUSB
truly a sub-device of the glue drivers and passing always 2 resources
to it...

hmm.. you're right, but not completely. MUSB itself has 2 resources: 1
IRQ and 1 memory base. The other resources are part of the DMA. But at
least for arches with the Inventra DMA, they'll need the DMA IRQ and

   Not only them, CPPI 3.1 on DM6467 too.

since that's likely not going to use DMA Engine, I'm not sure we have a
way out.

We can always use musb->controller->parent to get to the glue DMA resources. At least that's what I'm going to do.

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux