Oh! Bummer, I rant the tool but somehow I missed it. I will add the tool, change and resend patch. Thank you, Alexandra. -----Original Message----- From: Sarah Sharp [mailto:sarah.a.sharp@xxxxxxxxxxxxxxx] Sent: Friday, August 09, 2013 4:43 PM To: Yates, Alexandra Cc: Alexandra Yates; gregkh@xxxxxxxxxxxxxxxxxxx; linux-usb@xxxxxxxxxxxxxxx Subject: Re: [RFC v3] xhci-hub: Roothub USB2.0 descriptor for BESL DBESL Hi Alex, Can you make sure to add the checkpatch.pl to your git pre-commit hooks? This patch fails checkpatch: sarah@xanatos:~/git/kernels/xhci$ git am -s ~/Maildir.fetchmail/.to-apply Applying: xhci-hub: Roothub USB2.0 descriptor for BESL DBESL ERROR: spaces prohibited around that '->' (ctx:WxV) #52: FILE: drivers/usb/host/xhci-hub.c:727: + } else if (hcd ->speed == HCD_USB2) { ^ ERROR: code indent should use tabs where possible #56: FILE: drivers/usb/host/xhci-hub.c:731: + /* Set first byte of bmAttributes in the$ ERROR: code indent should use tabs where possible #57: FILE: drivers/usb/host/xhci-hub.c:732: + * usb2_bos_descriptor */$ total: 3 errors, 0 warnings, 82 lines checked Please fix these and resend. Sarah Sharp On Fri, Aug 09, 2013 at 08:32:32PM +0000, Yates, Alexandra wrote: > Will do! Thank you Sarah and Greg for the great feedback to make this patch better :) > > > Thank you, > > Alexandra. > > -----Original Message----- > From: linux-usb-owner@xxxxxxxxxxxxxxx [mailto:linux-usb-owner@xxxxxxxxxxxxxxx] On Behalf Of Sarah Sharp > Sent: Friday, August 09, 2013 1:03 PM > To: Alexandra Yates > Cc: gregkh@xxxxxxxxxxxxxxxxxxx; linux-usb@xxxxxxxxxxxxxxx > Subject: Re: [RFC v3] xhci-hub: Roothub USB2.0 descriptor for BESL DBESL > > Hi Alex, > > For just one patch, you don't need to send a cover letter, especially > when it contains the contents of your patch description. Also, please > use PATCH instead of RFC in the future. > > I'll test this patch out, and try to come up with a way to get the USB > core to use bcdUSB 2.10 for xHCI USB 2.0 roothubs. > > Sarah Sharp > > On Fri, Aug 09, 2013 at 12:20:49PM -0700, Alexandra Yates wrote: > > Modified the xHCI roothub descriptor to return USB2.0 extension > > descriptor Best Effort Service Latency (BESL) and Deep Best Effort > > Service Latency (DBESL) values when set on the xHCI host. > > > > On link power management the BESL and DBESL values are used to > > estimate L1 exit latency for USB2.0 host and devices. Tools such as > > PowerTop and lsusb will use BESL and DBESL values to > > monitor LPM L1 exit latency. Additionally, by presenting the host > > controller BESL and DBESL values one could check if the BIOS or > > firmware is setting these values correctly. > > > > Currently the root hub device descriptor bcdUSB value is set to zero > > by the BIOS. Therefore to test this functionality with lsusb, I hard > > coded the usb2_rh_dev_descriptor (not include on patch) to: > > bcdUSB 0x01. > > > > Alexandra Yates (1): > > xhci-hub: Roothub USB2.0 descriptor for BESL DBESL > > > > drivers/usb/host/xhci-hub.c | 53 +++++++++++++++++++++++++++++++++++++++---- > > drivers/usb/host/xhci.h | 3 +++ > > 2 files changed, 51 insertions(+), 5 deletions(-) > > > > -- > > 1.7.9.5 > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-usb" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
