On Wed, May 15, 2013 at 01:59:39PM +0300, Alexander Shishkin wrote: > Sascha Hauer <s.hauer@xxxxxxxxxxxxxx> writes: > > > On Wed, May 15, 2013 at 01:34:31PM +0300, Alexander Shishkin wrote: > >> Peter Chen <peter.chen@xxxxxxxxxxxxx> writes: > >> > >> > Hi Michael & Marc, > >> > > >> > Recently, I have worked at i.mx USB loadable module support for chipidea driver, > >> > it needs to write non-core register during the ci13xxx_imx remove process, > >> > but currently, the usbmisc_imx is a driver, and it uses symbol from > >> > ci13xxx_imx, so it will be unload first. > >> > >> One driver really shouldn't be using symbols from another driver, we > >> should fix that first. > >> > >> > How about I make usbmisc_imx as lib, and using DT entries from ci13xxx_imx? > >> > In fact, if we need support full feature usb functions, it needs touch > >> > non-core register from time to time, eg disable/enable wakeup during > >> > runtime-pm. > >> > >> Can we move usbmisc_imx code to the imx platform pm code or something? I > >> suspect it's only needed during probe/remove time or power state > >> transitions. > > > > We are currently moving driver specific stuff *out* of architecture > > code, so no. > > This is not driver specific. Nothing else but imxes have these non-core > registers, yet here we are, with a *generic* driver for that. This may not be chipidea specific, but still it's driver specific. Having this stuff next to the driver is the right thing IMO. No need to make the usbmisc stuff a separate module though, it could be a part of the chipidea driver. Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
