Sascha Hauer <s.hauer@xxxxxxxxxxxxxx> writes: > On Wed, May 15, 2013 at 01:34:31PM +0300, Alexander Shishkin wrote: >> Peter Chen <peter.chen@xxxxxxxxxxxxx> writes: >> >> > Hi Michael & Marc, >> > >> > Recently, I have worked at i.mx USB loadable module support for chipidea driver, >> > it needs to write non-core register during the ci13xxx_imx remove process, >> > but currently, the usbmisc_imx is a driver, and it uses symbol from >> > ci13xxx_imx, so it will be unload first. >> >> One driver really shouldn't be using symbols from another driver, we >> should fix that first. >> >> > How about I make usbmisc_imx as lib, and using DT entries from ci13xxx_imx? >> > In fact, if we need support full feature usb functions, it needs touch >> > non-core register from time to time, eg disable/enable wakeup during >> > runtime-pm. >> >> Can we move usbmisc_imx code to the imx platform pm code or something? I >> suspect it's only needed during probe/remove time or power state >> transitions. > > We are currently moving driver specific stuff *out* of architecture > code, so no. This is not driver specific. Nothing else but imxes have these non-core registers, yet here we are, with a *generic* driver for that. Regards, -- Alex -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
