On 2013年04月06日 15:34, Chen Gang wrote:
> On 2013年04月03日 17:25, Chen Gang wrote:
>> inside the 'for' looping:
>> the return value 'rv' may override if not have a check in time.
>>
>> the next checking (outside the 'for' looping):
>> can not find failure which generated during the 'for' looping
>>
>> the fix is for:
>> let outside know about the failure, and not stop servicing the
>> other ports just because there is an error in another port.
>>
>>
>> Signed-off-by: Chen Gang <gang.chen@xxxxxxxxxxx>
>> Signed-off-by: Oliver Neukum <oneukum@xxxxxxx>
>> ---
>
> Hello Greg KH:
>
> according to what you said for another patches of mine.
>
> I need test it, firstly.
> and then resend it without "Signed-off-by: Oliver Neukum <oneukum@xxxxxxx>".
>
> is it correct ?
>
>
> thanks.
>
excuse me, I have no related hard ware, and seems not easy to virtualizing.
so I think of an idea to test it, please help check whether it is OK.
our demands:
our test goal is to check what we modified whether can work correctly.
it only has effect within the function mos7840_interrupt_callback.
it only has effect with the work flow procedure.
so what we should do is
test mos7840_interrupt_callback work flow procedure with our modification.
plan to do:
will make a driver which will call function mos7840_interrupt_callback.
rewrite all sub functions which mos7840_interrupt_callback will call.
such as mos7840_get_port_private, mos7840_get_reg, and usb_submit_urb.
provide related data to cover all related work flow procedures.
a. let all things succeed (normal work flow).
b. let a failure occures at the first of the looping.
c. let a failure occures in the middle of the looping.
d. let a failure occures at the last of the looping.
e. let 2 failures occure during the looping.
f. let 3 failures occure during the looping (one at the first).
g. let 3 failures occure during the looping (one at the end).
welcome any suggestions or completions.
thanks.
By the way:
in this patch, I think "Signed-off-by: Oliver Neukum <oneukum@xxxxxxx>" is ok.
the reason is he gives necessary design information to direct implementaion.
--
Chen Gang
Asianux Corporation
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
