On 2013年04月03日 16:12, Oliver Neukum wrote: > Good catch, but I am afraid the fix is wrong. You cannot stop servicing > the other ports just because there is an error in another port. > > Regards > Oliver ok, thanks. and how about my original fix for it ? (the related patch is below) :-) On 2013年04月01日 11:50, Chen Gang wrote: > > inside the 'for' looping: > the return value 'rv' may override if not have a check in time. > > next checking, outside the 'for' looping: > can not find failure which generated during the 'for' looping > > so need let outside know about the failure. > > > Signed-off-by: Chen Gang <gang.chen@xxxxxxxxxxx> > --- > drivers/usb/serial/mos7840.c | 4 +++- > 1 files changed, 3 insertions(+), 1 deletions(-) > > diff --git a/drivers/usb/serial/mos7840.c b/drivers/usb/serial/mos7840.c > index a0d5ea5..13aae1e 100644 > --- a/drivers/usb/serial/mos7840.c > +++ b/drivers/usb/serial/mos7840.c > @@ -651,7 +651,9 @@ static void mos7840_interrupt_callback(struct urb *urb) > wreg = MODEM_STATUS_REGISTER; > break; > } > - rv = mos7840_get_reg(mos7840_port, wval, wreg, &Data); > + if (mos7840_get_reg(mos7840_port, wval, > + wreg, &Data) < 0) > + rv = -1; > } > } > } > Asianux Corporation -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
