Re: [PATCH v2] USB: mos7840: looping issue: avoid the return value overriden by looping

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wednesday 03 April 2013 15:54:05 Chen Gang wrote:
> 
>   inside the 'for' looping:
>     the return value 'rv' may override if not have a check in time.
> 
>   the next checking (outside the 'for' looping):
>     can not find failure which generated during the 'for' looping
> 
>   so need let outside know about the failure.
> 
>   the original related commit is:
>     commit 0de9a7024e7ae62512d080c7e2beb59d82958cd5
>     Author: Oliver Neukum <oneukum@xxxxxxx>
>     Date:   Fri Mar 16 20:28:28 2007 +0100

Hi,

Good catch, but I am afraid the fix is wrong. You cannot stop servicing
the other ports just because there is an error in another port.

	Regards
		Oliver

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux