-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Arnd Bergmann wrote: > On Thursday 04 April 2013, Felipe Balbi wrote: >> On Thu, Apr 04, 2013 at 01:42:18PM -0400, Alan Stern wrote: >>>>> diff --git a/drivers/usb/misc/sisusbvga/Kconfig b/drivers/usb/misc/sisusbvga/Kconfig >>>>> index 30ea7ca..0d03a52 100644 >>>>> --- a/drivers/usb/misc/sisusbvga/Kconfig >>>>> +++ b/drivers/usb/misc/sisusbvga/Kconfig >>>>> @@ -1,7 +1,7 @@ >>>>> >>>>> config USB_SISUSBVGA >>>>> tristate "USB 2.0 SVGA dongle support (Net2280/SiS315)" >>>>> - depends on USB && (USB_MUSB_HDRC || USB_EHCI_HCD) >>>>> + depends on (USB_MUSB_HDRC || USB_EHCI_HCD) >>>> is it just me or would everybody agree that depending on MUSB or EHCI >>>> here is wrong ? >>> That line certainly looks like it could be removed entirely. Perhaps >>> the original author can enlighten us. >>> >>> In any case, it's not relevant to the purpose of this patch set. >> right :-) >> > > Originally it had just "depends on USB_EHCI_HCD" and the text mentions that > it requires USB 2.0, so it probably comes from a time where EHCI was the > only high speed capable USB HCD. > > Arnd > That's exactly right. Thomas - -- Thomas Winischhofer thomas AT winischhofer DOT net -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.7 (Darwin) iD8DBQFRX/A3zydIRAktyUcRAo+YAJ9bmOrODMsIiBessMNnrmYJLYvmhwCgyABL z9A6pb1sab2VwnI8i5v3bCI= =HNat -----END PGP SIGNATURE----- -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html