On Mon, Feb 25, 2013 at 09:03:27AM +0200, Felipe Balbi wrote: > Don't register anything non-generic under > the gadget's device as we don't really *own* > it. Hi Felipe, Would you like to explain why it is not suitable? If it is a otg device, we may not want to see gadget debug things at device's sys entry when it is at host mode. > > Signed-off-by: Felipe Balbi <balbi@xxxxxx> > --- > > Hi Alex, > > please take a look at this patch, if you don't reply to it > I will take it through my tree for this -rc cycle. I have sent > few weeks ago and didn't get a review. > > cheers > > drivers/usb/chipidea/udc.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/usb/chipidea/udc.c b/drivers/usb/chipidea/udc.c > index 2f45bba..f64fbea 100644 > --- a/drivers/usb/chipidea/udc.c > +++ b/drivers/usb/chipidea/udc.c > @@ -1767,7 +1767,7 @@ static int udc_start(struct ci13xxx *ci) > goto put_transceiver; > } > > - retval = dbg_create_files(&ci->gadget.dev); > + retval = dbg_create_files(ci->dev); > if (retval) > goto unreg_device; > > @@ -1796,7 +1796,7 @@ remove_trans: > > dev_err(dev, "error = %i\n", retval); > remove_dbg: > - dbg_remove_files(&ci->gadget.dev); > + dbg_remove_files(ci->dev); > unreg_device: > device_unregister(&ci->gadget.dev); > put_transceiver: > @@ -1836,7 +1836,7 @@ static void udc_stop(struct ci13xxx *ci) > if (ci->global_phy) > usb_put_phy(ci->transceiver); > } > - dbg_remove_files(&ci->gadget.dev); > + dbg_remove_files(ci->dev); > device_unregister(&ci->gadget.dev); > /* my kobject is dynamic, I swear! */ > memset(&ci->gadget, 0, sizeof(ci->gadget)); > -- > 1.8.1.rc1.5.g7e0651a > > -- > To unsubscribe from this list: send the line "unsubscribe linux-usb" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- Best Regards, Peter Chen -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
