Re: [PATCH v9 8/9] usb: chipidea: tell platform layer the ci core probe's result

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Feb 17, 2013 at 05:24:42PM +0800, Peter Chen wrote:
> If the probe fails, the ci13xxx_add_device will not return error,
> (bus_probe_device doesn't has return value)
> therefore, the platform layer can't know whether core's probe
> is successful or not, if platform layer goes on using core's struct
> which is initialized at core's probe, the error will occur.
> 
> This error is showed when I only compile gadget, the host-only
> controller reports "no supported roles", and fails probe, but imx
> platform code doesn't know it, and goes on using core's private data.
> 
> Signed-off-by: Peter Chen <peter.chen@xxxxxxxxxxxxx>

this just tells you that platform code shouldn't be using the driver
directly. passing probe_retval via platform_data is an abomination, fix
the real problem instead, whatever it is.

-- 
balbi

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux