Re: [PATCH 1/3] USB: EHCI: prepare to make ehci-hcd a library module

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Nov 01, 2012 at 11:12:58AM -0400, Alan Stern wrote:
> This patch (as1624) prepares ehci-hcd for being split up into a core
> library and separate platform driver modules.  A generic
> ehci_hc_driver structure is created, containing all the "standard"
> values, and a new mechanism is added whereby a driver module can
> specify a set of overrides to those values.  In addition the
> ehci_setup(), ehci_suspend(), and ehci_resume() routines need to be
> EXPORTed for use by the drivers.
> 
> As a side effect of this change, a few routines no longer need to be
> marked __maybe_unused.
> 
> Signed-off-by: Alan Stern <stern@xxxxxxxxxxxxxxxxxxx>
> CC: Felipe Balbi <balbi@xxxxxx>
> 
> ---
> 
>  drivers/usb/host/ehci-hcd.c |   73 ++++++++++++++++++++++++++++++++++++++++++--
>  drivers/usb/host/ehci-hub.c |    6 +--
>  drivers/usb/host/ehci.h     |   17 ++++++++++
>  3 files changed, 89 insertions(+), 7 deletions(-)
> 
> Index: usb-3.7/drivers/usb/host/ehci.h
> ===================================================================
> --- usb-3.7.orig/drivers/usb/host/ehci.h
> +++ usb-3.7/drivers/usb/host/ehci.h
> @@ -781,4 +781,21 @@ static inline u32 hc32_to_cpup (const st
>  
>  /*-------------------------------------------------------------------------*/
>  
> +/* Declarations of things exported for use by ehci platform drivers */
> +
> +struct ehci_driver_overrides {
> +	const char	*product_desc;

just one question: do we really need to allow for product_desc override?
Isn't it enough to just call it "EHCI Host Controller" or "Enhanced Host
Controller Interface"

-- 
balbi

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux