On Tue, Nov 6, 2012 at 9:20 PM, Steve Glendinning <steve@xxxxxxxxxxx> wrote: > On 6 November 2012 01:45, Ming Lei <ming.lei@xxxxxxxxxxxxx> wrote: >> This patch fixes memory leak in smsc95xx_suspend. > > Good spot, thanks! > > Note that check_warn_return just above your kfree can cause early > return in the error case, which would still leak filter_mask, so we > might want to explicitly expand that instance of the helper macro. OK, will update the patch. BTW, I just saw the smsc95xx datasheet and the vendor's driver source code, and found the chip supports runtime PM well (remote wakeup on 'good packet' or link change), so do you plan to implement that? Thanks, -- Ming Lei -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
