On Tue, 6 Nov 2012, Felipe Balbi wrote:
> On Thu, Nov 01, 2012 at 11:12:58AM -0400, Alan Stern wrote:
> > This patch (as1624) prepares ehci-hcd for being split up into a core
> > library and separate platform driver modules. A generic
> > ehci_hc_driver structure is created, containing all the "standard"
> > values, and a new mechanism is added whereby a driver module can
> > specify a set of overrides to those values. In addition the
> > ehci_setup(), ehci_suspend(), and ehci_resume() routines need to be
> > EXPORTed for use by the drivers.
> > +/* Declarations of things exported for use by ehci platform drivers */
> > +
> > +struct ehci_driver_overrides {
> > + const char *product_desc;
>
> just one question: do we really need to allow for product_desc override?
> Isn't it enough to just call it "EHCI Host Controller" or "Enhanced Host
> Controller Interface"
It's not a big issue, as far as I can see. This value appears as the
Product string in the root hub's device descriptor, and it appears in
the system log each time a new host controller is added, but it doesn't
affect anything else.
If you think it shouldn't be overridden, I'm willing to change the new
code.
Alan Stern
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
