Re: [PATCH 6/8] usb/gadget: free requests in pn_bind()'s error path

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello.

On 16-09-2012 23:58, Sebastian Andrzej Siewior wrote:

Signed-off-by: Sebastian Andrzej Siewior <bigeasy@xxxxxxxxxxxxx>
---
  drivers/usb/gadget/f_phonet.c |    8 ++++++--
  1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/drivers/usb/gadget/f_phonet.c b/drivers/usb/gadget/f_phonet.c
index 8ee9268..a6c19a4 100644
--- a/drivers/usb/gadget/f_phonet.c
+++ b/drivers/usb/gadget/f_phonet.c
[...]
@@ -540,14 +540,18 @@ int pn_bind(struct usb_configuration *c, struct usb_function *f)
  	/* Outgoing USB requests */
  	fp->in_req = usb_ep_alloc_request(fp->in_ep, GFP_KERNEL);
  	if (!fp->in_req)
-		goto err;
+		goto err_req;

  	INFO(cdev, "USB CDC Phonet function\n");
  	INFO(cdev, "using %s, OUT %s, IN %s\n", cdev->gadget->name,
  		fp->out_ep->name, fp->in_ep->name);
  	return 0;

+err_req:
+	for (i = 0; i < phonet_rxq_size && fp->out_reqv[i]; i++)
+		usb_ep_free_request(fp->out_ep, fp->out_reqv[i]);
  err:
+

   Why empty line here?

  	if (fp->out_ep)
  		fp->out_ep->driver_data = NULL;
  	if (fp->in_ep)

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux