Re: [PATCH 6/8] usb/gadget: free requests in pn_bind()'s error path

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 09/17/2012 01:34 PM, Sergei Shtylyov wrote:
--- a/drivers/usb/gadget/f_phonet.c
+++ b/drivers/usb/gadget/f_phonet.c
[...]
@@ -540,14 +540,18 @@ int pn_bind(struct usb_configuration *c, struct
<snip>

+err_req:
+ for (i = 0; i < phonet_rxq_size && fp->out_reqv[i]; i++)
+ usb_ep_free_request(fp->out_ep, fp->out_reqv[i]);
err:
+

Why empty line here?

It got probably that way while merging and splitting patches and git
did auto merging or something.
Unless you insists in removing that one I would keep that patch as it
because it gets removed/replaced in 8/8 so there is no empty line.

if (fp->out_ep)
fp->out_ep->driver_data = NULL;
if (fp->in_ep)

WBR, Sergei

Sebastian
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux