Re: [PATCH 3/8] usb/gadget: remove c->highpseed = true from f_mini and uac1

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello.

On 16-09-2012 23:58, Sebastian Andrzej Siewior wrote:

Whether highspeed configuration is valid or not is something that
composite decides and not the gadget. That gadget can only provide the
required descriptors for it.

Signed-off-by: Sebastian Andrzej Siewior <bigeasy@xxxxxxxxxxxxx>
---
  drivers/usb/gadget/f_midi.c |    1 -
  drivers/usb/gadget/f_uac1.c |    1 -
  2 files changed, 2 deletions(-)

[...]

diff --git a/drivers/usb/gadget/f_uac1.c b/drivers/usb/gadget/f_uac1.c
index 1a5dcd5..c8ed41b 100644
--- a/drivers/usb/gadget/f_uac1.c
+++ b/drivers/usb/gadget/f_uac1.c
@@ -667,7 +667,6 @@ f_audio_bind(struct usb_configuration *c, struct usb_function *f)
  	 * both speeds
  	 */
  	if (gadget_is_dualspeed(c->cdev->gadget)) {
-		c->highspeed = true;
  		f->hs_descriptors = usb_copy_descriptors(f_audio_desc);
  	}

   Should have removed {} as well. Doesn't checkpatch.pl warn about them?

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux