Re: [PATCH 8/9] usb/gadget: Add I2C dependency for USB_LPC32XX

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Aug 22, 2012 at 01:56:56PM +0200, Sebastian Andrzej Siewior wrote:
> On 08/22/2012 01:43 PM, Felipe Balbi wrote:
> >>But now that I've seen the transceiver driver it is probably the
> >>smallest one.
> >
> >if it depends on the transceiver, why do we have i2c transfers on those
> >drivers ? They should be hidden by the usb_phy_*() calls.
> 
> Unless Roland has other plans now I would hide both (the gadget and
> ohci) behind the PHY bar.

correct. that isp1301.c is ridiculous. It's not using the (simple) phy
layer we have now at all. It's also completely preventing multiple
instances of this driver to be used. Quite silly implementation.

-- 
balbi

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux