Re: [PATCH 8/9] usb/gadget: Add I2C dependency for USB_LPC32XX

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On 08/15/2012 09:59 PM, Sebastian Andrzej Siewior wrote:
> | drivers/usb/gadget/lpc32xx_udc.c: In function ‘isp1301_udc_configure’:
> | drivers/usb/gadget/lpc32xx_udc.c:606: error: implicit declaration of function ‘i2c_smbus_write_byte_data’
> | drivers/usb/gadget/lpc32xx_udc.c:665: error: implicit declaration of function ‘i2c_smbus_read_word_data’
> | drivers/usb/gadget/lpc32xx_udc.c: In function ‘vbus_work’:
> | drivers/usb/gadget/lpc32xx_udc.c:2959: error: implicit declaration of function ‘i2c_smbus_read_byte_data’
> 
> Cc: Alexandre Pereira da Silva <aletes.xgr@xxxxxxxxx>
> Cc: Roland Stigge <stigge@xxxxxxxxx>
> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@xxxxxxxxxxxxx>
> ---
>  drivers/usb/gadget/Kconfig |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/gadget/Kconfig b/drivers/usb/gadget/Kconfig
> index 51ab5fd..8d33788 100644
> --- a/drivers/usb/gadget/Kconfig
> +++ b/drivers/usb/gadget/Kconfig
> @@ -143,7 +143,7 @@ config USB_AT91
>  
>  config USB_LPC32XX
>  	tristate "LPC32XX USB Peripheral Controller"
> -	depends on ARCH_LPC32XX
> +	depends on ARCH_LPC32XX && I2C
>  	select USB_ISP1301
>  	help
>  	   This option selects the USB device controller in the LPC32xx SoC.

USB_ISP1301 already depends on I2C.

Maybe we should rather let USB_LPC32XX "depends on USB_ISP1301" instead
of "select USB_ISP1301"?

Thanks in advance,

Roland
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux