On Tue, May 15, 2012 at 06:53:18PM +0200, Bjørn Mork wrote:
> Greg KH <greg@xxxxxxxxx> writes:
> > On Mon, May 14, 2012 at 11:31:51PM -0400, Russell Nelson wrote:
> >> On Mon, May 14, 2012 at 6:56 PM, Greg KH <greg@xxxxxxxxx> wrote:
> >>
> >> > Again the usb-serial generic device is a very dumb, slow device, with no
> >> > line settings at all. It's ment for testing and one-off prototypes, not
> >> > for "real" devices in any way.
> >>
> >> Okay, I am *seriously* confused, then, because I've seen instructions
> >> on the 'net that used to work which tell me to modprobe usbserial with
> >> a vendor and product number. Is "usb-serial not a functioning driver"
> >> new information that I missed?
> >
> > Yes, and all of that is wrong and written by people who have no idea
> > what they are doing.
> >
> >> Maybe when it creates its entry in
> >> /sys/bus/usb-serial/drivers/generic/ it should say "testing" instead
> >> of "generic", because "generic" implies to me that it's going to work
> >> with just about anything. You know, like generic drugs.
> >
> > True, but it's too late now, and it's not like changing that will make
> > anyone realize the problem.
> >
> > It usually happens when people start reporting "my device is so slow"
> > that they let us know what the new device ids are, and we add them to
> > the real drivers and then people are happy.
> >
> > If you can think of something that I can do to fix the above web sites,
> > I'll be very happy.
>
> You could make some probe noise maybe? Not everybody will notice, but
> some may.
>
> diff --git a/drivers/usb/serial/usb-serial.c b/drivers/usb/serial/usb-serial.c
> index 62dd922..e1b5b74 100644
> --- a/drivers/usb/serial/usb-serial.c
> +++ b/drivers/usb/serial/usb-serial.c
> @@ -845,6 +845,8 @@ static int usb_serial_probe(struct usb_interface *interface,
> module_put(type->driver.owner);
> return -EIO;
> }
> + dev_info(&interface->dev, "\"generic\" usb-serial driver is only for testing and one-off prototypes\n");
> + dev_info(&interface->dev, "tell linux-usb@xxxxxxxxxxxxxxx to add your device to a proper driver\n");
> }
> #endif
> if (!num_ports) {
Looks good to me, I'll go make this change, care to provide a
Signed-off-by: for it?
greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
