> Does this mean we can drop that driver now? It seems to support more > devices than yours does. At the least, can I remove the matching device > ids from the serqt_usb2 driver at this point in time? > My driver should replace the one staging/quatech_usb2. It should have all the same device ids. The serqt_usb2 driver attempts to combine support for Quatech's USB 1 (the 0xC0 ids) and USB 2 (0xC1 ids) adapters. While I think it's possible to combine them into one driver, I'm pretty confident that the one in staging doesn't do it. I can look it and tell it won't work with USB 2 devices since it doesn't attempt to set the first 5 bytes of a write to the values those devices expect. It might come closer to working with the USB 1 devices, but I know when it claimed support for the SSU100 device it didn't work for that one (it'd say it had 8 ports). So, at the very least I'd say staging/quatech_usb2 can go and 0xC1 device ids should be removed from staging/serqt_usb2. If I ever run across a Quatech USB 1 multi-port device, I can either modify ssu100 to deal with it or merge it all into one driver. > > Care to add a follow-on patch that adds your copyright and a simple > license header for this file? It is good to have that on all kernel > files. > Ah, ok I'll add it and send it along shortly. I didn't think to add that stuff since it's just me. -- Bill -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
