On Thu, May 10, 2012 at 04:28:03PM -0400, Bill Pemberton wrote: > > Does this mean we can drop that driver now? It seems to support more > > devices than yours does. At the least, can I remove the matching device > > ids from the serqt_usb2 driver at this point in time? > > > > My driver should replace the one staging/quatech_usb2. It should have > all the same device ids. > > The serqt_usb2 driver attempts to combine support for Quatech's USB 1 > (the 0xC0 ids) and USB 2 (0xC1 ids) adapters. While I think it's > possible to combine them into one driver, I'm pretty confident that > the one in staging doesn't do it. I can look it and tell it won't > work with USB 2 devices since it doesn't attempt to set the first 5 > bytes of a write to the values those devices expect. It might come > closer to working with the USB 1 devices, but I know when it claimed > support for the SSU100 device it didn't work for that one (it'd say it > had 8 ports). > > So, at the very least I'd say staging/quatech_usb2 can go and 0xC1 > device ids should be removed from staging/serqt_usb2. If I ever run > across a Quatech USB 1 multi-port device, I can either modify ssu100 > to deal with it or merge it all into one driver. Ok, I've now removed the device ids from the serqt_usb2 driver, and deleted the quatech_usb2 driver, so all should be good. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
