Re: [PATCH] USB: serial: add quatech2 usb to serial driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, May 10, 2012 at 03:36:02PM -0400, Bill Pemberton wrote:
> This supports the Quatech USB 2 usb to serial adapters.
> 
> Signed-off-by: Bill Pemberton <wfp5p@xxxxxxxxxxxx>
> ---
> 
> This driver supports the same devices as the serqt_usb2 driver in staging.  I
> found it easier to rewrite the driver than to try to fix the staging driver.

Very nice, thanks for doing this.

Does this mean we can drop that driver now?  It seems to support more
devices than yours does.  At the least, can I remove the matching device
ids from the serqt_usb2 driver at this point in time?

> --- /dev/null
> +++ b/drivers/usb/serial/quatech2.c
> @@ -0,0 +1,1149 @@
> +/*
> + * usb-serial driver for Quatech USB 2 devices
> + *
> + *
> + *  These devices all have only 1 bulk in and 1 bulk out that is shared
> + *  for all serial ports.
> + *
> + */

Care to add a follow-on patch that adds your copyright and a simple
license header for this file?  It is good to have that on all kernel
files.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux