> >
> > > We should try and resolve this issue together. I'm providing my
> > > support in every possible way, even offering to alter functions to
> > return values for imx platforms.
> > >
> > > You cannot keep asking people to send patches for the platforms that
> > > imx team is supposed to maintain...we need to work together to
> resolve
> > issues...
> > >
> > Ramneek, your patch causes i.mx compile error, the reason is you add
> > struct(register) which
> > is not defined at i.mx platform. WHY do you think it is i.mx team's
> duty?
> >
> Peter, I said this in context of usage of CONFIG_ARCH_MXC macro in usb
> gadget
> driver. It doesn't matter who's adding what code in the driver, the basic
> notion is to make sure not to use soc specific macros/ code inside driver
> code
> someone from imx team can help me in getting rid of CONFIG_ARCH_MXC macro.
>
> The main reason for me sending this patch is also this. Initially, I was
> also
> using ...BOOKE macro for this code, but later realized this issue, and
> wrote
> usb_get_ver_info() function to identify controller version
>
> as long as code compilation issue on IMX is concerned, I'm still trying
> to
> find the best possible way to resolve it...but I would really appreciate
> some
> help from your side as I'm not very much aware of imx code structure...
Ramneek, please. All code with CONFIG_ARCH_MXC is using #ifndef.
All code at fsl_udc_core.c with macros are non i.mx code except register access code
like fsl_read/write(). Your guys should be more familiar with things like
struct usb_sys_interface *usb_sys_regs, and I have said again and again
there is NO struct usb_sys_interface *usb_sys_regs at i.mx platform.
We should not spend time on deciding who to do that. I have two suggestions, you and leo can
choose one for current situation. Any one of the two is OK for me.
1.Replace
#ifndef CONFIG_ARCH_MXC
#endif
to
if (pdata->have_sysif_regs)
{}
I can post a patch for that, then you post your v5 patch based on it.
2. Move the code related struct usb_sys_interface *usb_sys_regs out of fsl_udc_core.c.
The guy from PowerPC should post a patch for that, as it is PowerPC's register.
If you and Leo have better idea, please suggest.
BR,
Peter
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
