> > > > > > Top commit > > > commit 5407a3c3d942e75d4d123d213fd692bce5acc961 > > > Author: Felipe Balbi <balbi@xxxxxx> > > > Date: Wed Feb 15 09:34:26 2012 +0200 > > > > > > Hi Peter, could you please help me test this patch in IMX platform > > It causes compile error at i.mx platform due to struct > usb_sys_interface > > *usb_sys_regs is only defined at PowerPC platform. > > Below is the error message: > > > > /home/b29397/work/code/git/linus/linux- > > 2.6/drivers/usb/gadget/fsl_udc_core.c: In function > 'dr_controller_setup': > > /home/b29397/work/code/git/linus/linux- > > 2.6/drivers/usb/gadget/fsl_udc_core.c:269: error: 'ctrl' undeclared > > (first use in this function) > > /home/b29397/work/code/git/linus/linux- > > 2.6/drivers/usb/gadget/fsl_udc_core.c:269: error: (Each undeclared > > identifier is reported only once > > /home/b29397/work/code/git/linus/linux- > > 2.6/drivers/usb/gadget/fsl_udc_core.c:269: error: for each function it > > appears in.) > > /home/b29397/work/code/git/linus/linux- > > 2.6/drivers/usb/gadget/fsl_udc_core.c:269: error: 'usb_sys_regs' > > undeclared (first use in this function) > > make[4]: *** [drivers/usb/gadget/fsl_udc_core.o] Error 1 > > make[3]: *** [drivers/usb/gadget] Error 2 > > > These will come since there are IMX SOC based macros which are excluding > ctrl and usb_sys_regs for IMX platforms with CONFIG_ARCH_MXC macro > > The only way to resolve this is that USB controller version of IMX can be > added in some IMX configuration/platform file, and CONFIG_ARCH_MXC is > removed > from USB gadget driver file...we should refrain from including SOC based > macros in IP driver files > > Can you or someone from IMX team support this...I'm not too familiar with > IMX platform > The current problem is usb_sys_regs has not defined at i.mx platform, not related your USB controller version code. Temp way: Use pdata->have_sysif_regs to judge where the usb_sys_regs can be accessed, and keep as much as access usb_sys_regs code to a function to keep code clean. Long way: Does usb_sys_regs are related to PHY? Move all PHY related operation out of controller file, as PHY is platform related. In fact, i.mx has similar PHY registers, currently, we put it at arch code, but it needs to move to PHY driver in future. BR, Peter -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
