RE: [PATCH][v4]fsl/usb:Add controller version based ULPI and UTMI phy support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



 
> I see 2 issues here:
> 
> 	1. Device-tree not being used for IMX platforms
> 	2. sysif_regs not defined for IMX platforms
> 
> 	For the first issue, I can replace CONFIG_ARCH_MXC macro with
> usb_get_ver_info()
> 	returning some standard error value for nonDT platforms
> 
> 	For the second issue, we can replace CONFIG_ARCH_MXC macro with
> 	if (pdata->have_sysif_regs) for IMX platforms
> 
> 	Is it possible to define pdata->have_sysif_regs = 0 for IMX
> platforms ??
> 

Please grep the source, you will find the i.mx does not define have_sysif_regs
> Regards,
> Ramneek
> >
> > > Instead of using CONFIG_ARCH_MXC macro, usb_get_ver_info() can be
> used
> > > to shield this code for IMX based platforms...as discussed previously,
> > > this function returns 0 for IMX platforms...
> > >
> > Your code is ok, the problem is your code uses the structure which is
> not
> > defined at i.mx platform.
> >
> > > Regards,
> > > Ramneek
> > >


--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux