[snip] >>Besides, I am not sure drivers/usb/host/fsl/ is a good place to put >>your fsl_usb.h. >>My suggestion is move it to: include/linux/usb/. >> >>[Ramneek]: Hi Peter, "include/linux/usb/" contains generic usb code >>headers for usb core. I do not want to put fsl specific code there. I >>had this discussion with Greg regarding this, and he agreed for the >>current location. Also, I have plans to move all fsl specific usb >>driver code inside "drivers/usb/host/fsl/" directory as this will make >>it easy to maintain fsl usb code in long term. Greg agreed for this >>also > >Hi Ramneek, > >If you want to make the usb_get_ver_info() generic to both host and udc, >why are you adding it to the drivers/usb/host/ directory instead of >somewhere common to both host and udc? I think >include/linux/fsl_devices.h is a good place. > >Also there is only one fsl specific usb driver under drivers/usb/host/. I >wonder if it is reasonable to add a fsl specific folder in this situation >while there is no other vendor specific folders. > >- Leo >[Ramneek]: Hi Leo, there are already 3 fsl specific files ehci-fsl.c, >ehci-fsl.h, and fsl-mph-dr-of.c. Ramneek, Please set your mail client to add ">" as prefix for quoted content. It is a convention for the mailing lists to make mail thread more readable. The Freescale specific driver I mentioned is fhci driver. The three files you said are part of the ehci driver, so it's not quite good to separate with the ehci core files. >I do agree that I should be putting this file somewhere in the common path. >I had a discussion with Greg regarding this. It struck to me that it's >better to move vendor specific driver files inside their respective >directories in USB host directory. > >I reckon include/linux/fsl_devices.h is also a good place. I can move this >file there also, but I will still recommend have a separate fsl directory >inside drivers/usb/host from code maintainability point of view. This >would also ensure that in future if more fsl files are added, they'll go >to this directory. It _is_ better to have vendor specific folder when there are too many drivers in the same folder like the ethernet drivers. But I don't think it's a good idea for folders with just a few drivers. There are not likely be many host drivers in the future too, as most chips are sharing the ehci driver. > >This file-location can be resolved in the final version, if no other >changes are required. > >Meanwhile, we need test this patch for IMX platform...I'm waiting for >Peter to give ack for that. Btw: Can you make the usb_get_ver_info() not static? It will make the binary duplicated when used by both host and udc. - Leo -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
