> > git am udc_Qoirp.patch > Applying: fsl/usb:Add controller version based ULPI and UTMI phy support > error: patch failed: drivers/usb/host/ehci-fsl.h:18 > error: drivers/usb/host/ehci-fsl.h: patch does not apply Patch failed at > 0001 fsl/usb:Add controller version based ULPI and UTMI phy support > > [Ramneek]: The patch was applying when I sent it few days back!! Probably > some change is accepted in drivers/usb/host/ehci-fsl.h file and you > updated the tree at your end before applying the patch...can you rebase > this patch ? I do not want to float another version just for this... > Hi Ramneek, please make sure always rebase to newest remote HEAD before sending your patch. Otherwise, how others to test your patch, how maintainer to apply your patch? > My HEAD is: > commit 19e00f2f1d5273dbc52eab0ebc315cae3aa44b2a > Merge: b05ee6b 1972345 > Author: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx> > Date: Thu Feb 9 13:52:57 2012 -0800 > > Merge tag 'tty-3.3-rc3' of > git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty > > > Signed-off-by: Ramneek Mehresh <ramneek.mehresh@xxxxxxxxxxxxx> > > --- > > Changes for v3: > > - added comment for non-dt users in definition of > > usb_get_ver_info() > > > > drivers/usb/gadget/fsl_udc_core.c | 25 ++++++++++++++- > > drivers/usb/gadget/fsl_usb2_udc.h | 13 ++++++++ > > drivers/usb/host/ehci-fsl.c | 35 +++++++++++++++++---- > > drivers/usb/host/ehci-fsl.h | 15 ++++++++- > > drivers/usb/host/fsl/fsl_usb.h | 61 > > +++++++++++++++++++++++++++++++++++++ > > 5 files changed, 141 insertions(+), 8 deletions(-) create mode > > 100644 drivers/usb/host/fsl/fsl_usb.h > > > Besides, I am not sure drivers/usb/host/fsl/ is a good place to put your > fsl_usb.h. > My suggestion is move it to: include/linux/usb/. > > [Ramneek]: Hi Peter, "include/linux/usb/" contains generic usb code > headers for usb core. I do not want to put fsl specific code there. I had > this discussion with Greg regarding this, and he agreed for the current > location. Also, I have plans to move all fsl specific usb driver code > inside "drivers/usb/host/fsl/" directory as this will make it easy to > maintain fsl usb code in long term. Greg agreed for this also > Besides, please always cc to the maintainer(Li Yang-R58472) > [Ramneek]: Will do > > BR, > Peter > > > > > > > -- > > To unsubscribe from this list: send the line "unsubscribe linux-usb" > > in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo > > info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
