>-----Original Message----- >From: Mehresh Ramneek-B31383 >Sent: Friday, February 10, 2012 6:20 PM >To: Chen Peter-B29397; linux-usb@xxxxxxxxxxxxxxx >Cc: Li Yang-R58472 >Subject: RE: [PATCH][v3]fsl/usb:Add controller version based ULPI and UTMI >phy support > > > >-----Original Message----- >From: Chen Peter-B29397 >Sent: Friday, February 10, 2012 3:23 PM >To: Mehresh Ramneek-B31383; linux-usb@xxxxxxxxxxxxxxx >Cc: Mehresh Ramneek-B31383; Li Yang-R58472 >Subject: RE: [PATCH][v3]fsl/usb:Add controller version based ULPI and UTMI >phy support > > > >> >> Add support for ULPI and UTMI PHYs based on usb controller version >> info read from device-tree >> >> Example of USB Controller versioning info: >> Version 1.2 and below : MPC8536, MPC8315, etc Version 1.6 : P1020, >> P1010, P2020, etc Version 2.2 : PSC9131, PSC9132, P3060, etc >> >> No changes for non-DT users >> >Hi Ramneek, > >I can't apply to your patch to current linus tree. >The error is: > >git am udc_Qoirp.patch >Applying: fsl/usb:Add controller version based ULPI and UTMI phy support >error: patch failed: drivers/usb/host/ehci-fsl.h:18 >error: drivers/usb/host/ehci-fsl.h: patch does not apply Patch failed at >0001 fsl/usb:Add controller version based ULPI and UTMI phy support > >[Ramneek]: The patch was applying when I sent it few days back!! Probably >some change is accepted in drivers/usb/host/ehci-fsl.h file and you >updated the tree at your end before applying the patch...can you rebase >this patch ? I do not want to float another version just for this... > >My HEAD is: >commit 19e00f2f1d5273dbc52eab0ebc315cae3aa44b2a >Merge: b05ee6b 1972345 >Author: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx> >Date: Thu Feb 9 13:52:57 2012 -0800 > > Merge tag 'tty-3.3-rc3' of >git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty > >> Signed-off-by: Ramneek Mehresh <ramneek.mehresh@xxxxxxxxxxxxx> >> --- >> Changes for v3: >> - added comment for non-dt users in definition of >> usb_get_ver_info() >> >> drivers/usb/gadget/fsl_udc_core.c | 25 ++++++++++++++- >> drivers/usb/gadget/fsl_usb2_udc.h | 13 ++++++++ >> drivers/usb/host/ehci-fsl.c | 35 +++++++++++++++++---- >> drivers/usb/host/ehci-fsl.h | 15 ++++++++- >> drivers/usb/host/fsl/fsl_usb.h | 61 >> +++++++++++++++++++++++++++++++++++++ >> 5 files changed, 141 insertions(+), 8 deletions(-) create mode >> 100644 drivers/usb/host/fsl/fsl_usb.h >> >Besides, I am not sure drivers/usb/host/fsl/ is a good place to put your >fsl_usb.h. >My suggestion is move it to: include/linux/usb/. > >[Ramneek]: Hi Peter, "include/linux/usb/" contains generic usb code >headers for usb core. I do not want to put fsl specific code there. I had >this discussion with Greg regarding this, and he agreed for the current >location. Also, I have plans to move all fsl specific usb driver code >inside "drivers/usb/host/fsl/" directory as this will make it easy to >maintain fsl usb code in long term. Greg agreed for this also Hi Ramneek, If you want to make the usb_get_ver_info() generic to both host and udc, why are you adding it to the drivers/usb/host/ directory instead of somewhere common to both host and udc? I think include/linux/fsl_devices.h is a good place. Also there is only one fsl specific usb driver under drivers/usb/host/. I wonder if it is reasonable to add a fsl specific folder in this situation while there is no other vendor specific folders. - Leo -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
