Re: [PATCH 03/10] usb/amd5536udc: move disconnect code into ISR

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Wed, Feb 08, 2012 at 11:10:13AM +0100, Thomas Dahlmann wrote:
> >>Soft reset on disconnect was needed for disconnects in the middle of
> >>a transfer. Then controller buffers and registers may remain in a
> >>kind of stuck state which can be resolved by a soft reset only.
> >
> >Nice.
> >
> >>I have to build up a system to play with the driver a little bit
> >>(haven't done that for a while).
> >
> >Okay. I was going rid of the tasklet because it did not look perfomance
> >critical or anything _and_ I was going to get rid of global variables.
> >You mask interrupts before disconnect and then you enable them later after the
> >reset. Do you think a workqueue would do the work?
> 
> I'm not familiar with work queues. I have read that they allow to run
> in process context and can sleep. But as they function as bottom
> halfs too it should work.
> 
> Is there any benefit from replacing the tasklet by a work queue?

wouldn't threaded IRQs work ?

-- 
balbi

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux