On 04.02.2012 18:55, Sebastian Andrzej Siewior wrote:
The disconnect code is scheduled in a tasklet. I don't see the point in doing this and the comment says that we may want do this in the irq. This patch is doing so.
The disconnect code should stay in a tasklet as a controller soft reset is done there. I remember issues when doing a controller soft reset inside interrupt context because the whole controller is wiped by reset.
Soft reset on disconnect was needed for disconnects in the middle of a transfer. Then controller buffers and registers may remain in a kind of stuck state which can be resolved by a soft reset only.
I have to build up a system to play with the driver a little bit (haven't done that for a while). Sebastian, thank you very much for your work. Thomas -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
