Hi, On Mon, Feb 06, 2012 at 02:58:15PM +0100, Sebastian Andrzej Siewior wrote: > * Felipe Balbi | 2012-02-06 15:40:41 [+0200]: > > >I'm not sure we will have such problems, I can update the commit log, > >but if someone wants to use this in BE, they cannot be penalized with a > >le32_to_cpu() everytime they want to do anything with the TRBs, because > >they can just set bit 12 of GSBUSCFG0 and the HW will start working in > >BE mode. > > The hardware is not working in BE mode, it will just swap the reads of > the descriptors. The register access is still LE unless they change indeed. > >What do you want me to add on commit log ? > It would be nice if you could denote this change in the commit log: > "There are no more little endian mode for the access of the TRB. There > are in CPU byte order now. On Powerpc bit12 of GSBUSCFG0 should be set > and do the right thing. If it is not, we can set this bit." sure, will update commit log. Thanks -- balbi
Attachment:
signature.asc
Description: Digital signature
