On Thu, 8 Dec 2011, Neil Zhang wrote:
> > > > --- a/drivers/usb/host/Kconfig
> > > > +++ b/drivers/usb/host/Kconfig
> > > > @@ -194,6 +194,15 @@ config USB_EHCI_S5P
> > > > help
> > > > Enable support for the S5P SOC's on-chip EHCI controller.
> > > >
> > > > +config USB_EHCI_PXA
> > > > + bool "EHCI support for PXA USB SPH and OTG controller"
> > > > + depends on USB_EHCI_HCD
> > > > + select USB_EHCI_ROOT_HUB_TT
> > > > + ---help---
> > > > + Enables support for PXA USB SPH and OTG controller. SPH is a
> > > > + single port host, and it can only be EHCI host. OTG is
> > controller
> > > > + that can switch to be host mode.
> > > > +
> > > > config USB_W90X900_EHCI
> > > > bool "W90X900(W90P910) EHCI support"
> > > > depends on USB_EHCI_HCD && ARCH_W90X900
> > > > diff --git a/drivers/usb/host/ehci-hcd.c b/drivers/usb/host/ehci-
> > hcd.c
> > > > index 3ff9f82..4eb19f8 100644
> > > > --- a/drivers/usb/host/ehci-hcd.c
> > > > +++ b/drivers/usb/host/ehci-hcd.c
> > > > @@ -1329,6 +1329,11 @@ MODULE_LICENSE ("GPL");
> > > > #define PLATFORM_DRIVER ehci_xls_driver
> > > > #endif
> > > >
> > > > +#ifdef CONFIG_USB_EHCI_PXA
> > > > +#include "ehci-mv.c"
> > > > +#define PLATFORM_DRIVER mv_ehci_driver
> > > > +#endif
> > > > +
> >
> > If this is a PXA driver, why is it named "ehci-mv.c"? Why not
> > "ehci-pxamv.c" or something like that?
> >
> > Also, I'm a little concerned by the fact that we already have
> > CONFIG_USB_PXA168_EHCI and ehci-pxa168.c. Adding CONFIG_USB_EHCI_PXA
> > could lead to a lot of confusion.
> >
> Actually, Marvell PXA and MMP serial all use the same USB IP and this driver is going to fit all of them.
> So is it OK if I change CONFIG_USB_EHCI_PXA to CONFIG_USB_EHCI_MV and will add some more info in Kconfig.
Yes, that will be okay.
Alan Stern
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
