Hi Alan, > -----Original Message----- > From: Alan Stern [mailto:stern@xxxxxxxxxxxxxxxxxxx] > Sent: 2011年12月7日 23:42 > To: Felipe Balbi > Cc: Neil Zhang; gregkh@xxxxxxx; USB list; Chao Xie > Subject: Re: [PATCH 1/7 v2] USB: EHCI: Add Marvell Host Controller > driver > > On Wed, 7 Dec 2011, Felipe Balbi wrote: > > > Hi, > > > > On Wed, Nov 30, 2011 at 09:57:11AM +0800, Neil Zhang wrote: > > > This patch adds support for EHCI compliant HSUSB Host controller > found > > > on Marvell Socs. > > > > > > It fits both OTG and SPH controller on marvell Socs, including > > > PXA920/MMP2/MMP3/MGx. > > > > > > Signed-off-by: Neil Zhang <zhangwm@xxxxxxxxxxx> > > > --- > > > > This is Alan's territory. Alan, any comments ? > > > > --- a/drivers/usb/host/Kconfig > > > +++ b/drivers/usb/host/Kconfig > > > @@ -194,6 +194,15 @@ config USB_EHCI_S5P > > > help > > > Enable support for the S5P SOC's on-chip EHCI controller. > > > > > > +config USB_EHCI_PXA > > > + bool "EHCI support for PXA USB SPH and OTG controller" > > > + depends on USB_EHCI_HCD > > > + select USB_EHCI_ROOT_HUB_TT > > > + ---help--- > > > + Enables support for PXA USB SPH and OTG controller. SPH is a > > > + single port host, and it can only be EHCI host. OTG is > controller > > > + that can switch to be host mode. > > > + > > > config USB_W90X900_EHCI > > > bool "W90X900(W90P910) EHCI support" > > > depends on USB_EHCI_HCD && ARCH_W90X900 > > > diff --git a/drivers/usb/host/ehci-hcd.c b/drivers/usb/host/ehci- > hcd.c > > > index 3ff9f82..4eb19f8 100644 > > > --- a/drivers/usb/host/ehci-hcd.c > > > +++ b/drivers/usb/host/ehci-hcd.c > > > @@ -1329,6 +1329,11 @@ MODULE_LICENSE ("GPL"); > > > #define PLATFORM_DRIVER ehci_xls_driver > > > #endif > > > > > > +#ifdef CONFIG_USB_EHCI_PXA > > > +#include "ehci-mv.c" > > > +#define PLATFORM_DRIVER mv_ehci_driver > > > +#endif > > > + > > If this is a PXA driver, why is it named "ehci-mv.c"? Why not > "ehci-pxamv.c" or something like that? > > Also, I'm a little concerned by the fact that we already have > CONFIG_USB_PXA168_EHCI and ehci-pxa168.c. Adding CONFIG_USB_EHCI_PXA > could lead to a lot of confusion. > Actually, Marvell PXA and MMP serial all use the same USB IP and this driver is going to fit all of them. So is it OK if I change CONFIG_USB_EHCI_PXA to CONFIG_USB_EHCI_MV and will add some more info in Kconfig. > Apart from that, the patch looks okay. > > Alan Stern Best Regards, Neil Zhang ?韬{.n?????%??檩??w?{.n???{炳???骅w* jg????????G??⒏ ⒎?:+v???????? ????＂??????
