Hi, On Mon, Nov 14, 2011 at 01:17:08AM -0800, Kuninori Morimoto wrote: > Hi Felipe > > Thank you for checking patch > > > > This patch cares latest USB_SPEED_SUPER support. > > > (renesas_usbhs can not use it though) > (snip) > > > if (!driver || > > > !driver->setup || > > > - driver->speed != USB_SPEED_HIGH) > > > + driver->speed < USB_SPEED_FULL) > > > > then this patch is wrong isn't it ? If renesas_usbhs isn't > > SuperSpeed-capable, why are you allowing probe() to go through ? > > > > I guess it's because some gadget drivers have USB_SPEED_SUPER as their > > max speed (?). I'll look closer into this one. > > In renesas_usbhs case, > ${LINUX}/drivers/usb/gadget/file_storage.c doesn't work, because of its speed. > What should I do in this case ? hmm, the semantics has changed. Now we have the max_speed, not the actual speed anymore. Maybe your patch is ok, but you need to be sure not to try to work on superspeed :-) -- balbi
Attachment:
signature.asc
Description: Digital signature