On 11/12/2011 04:46 PM, Jean-Christophe PLAGNIOL-VILLARD : > in commit aa6e52a35 we introduce the support of overcurrent notification > but the set and get of the power without checking if the gpio is valid or not > > Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@xxxxxxxxxxxx> > Cc: Thomas Petazzoni <thomas.petazzoni@xxxxxxxxxxxxxxxxxx> > Cc: Nicolas Ferre <nicolas.ferre@xxxxxxxxx> Acked-by: Nicolas Ferre <nicolas.ferre@xxxxxxxxx> > --- > drivers/usb/host/ohci-at91.c | 6 ++++++ > 1 files changed, 6 insertions(+), 0 deletions(-) > > diff --git a/drivers/usb/host/ohci-at91.c b/drivers/usb/host/ohci-at91.c > index ba3a46b..95a9fec 100644 > --- a/drivers/usb/host/ohci-at91.c > +++ b/drivers/usb/host/ohci-at91.c > @@ -223,6 +223,9 @@ static void ohci_at91_usb_set_power(struct at91_usbh_data *pdata, int port, int > if (port < 0 || port >= 2) > return; > > + if (pdata->vbus_pin[port] <= 0) > + return; > + > gpio_set_value(pdata->vbus_pin[port], !pdata->vbus_pin_inverted ^ enable); > } > > @@ -231,6 +234,9 @@ static int ohci_at91_usb_get_power(struct at91_usbh_data *pdata, int port) > if (port < 0 || port >= 2) > return -EINVAL; > > + if (pdata->vbus_pin[port] <= 0) > + return -EINVAL; > + > return gpio_get_value(pdata->vbus_pin[port]) ^ !pdata->vbus_pin_inverted; > } > -- Nicolas Ferre -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
