Re: [PATCH 3/5] usb: renesas_usbhs: fixup driver speed

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Felipe

Thank you for checking patch

> > This patch cares latest USB_SPEED_SUPER support.
> > (renesas_usbhs can not use it though)
(snip)
> >  	if (!driver		||
> >  	    !driver->setup	||
> > -	    driver->speed != USB_SPEED_HIGH)
> > +	    driver->speed < USB_SPEED_FULL)
> 
> then this patch is wrong isn't it ? If renesas_usbhs isn't
> SuperSpeed-capable, why are you allowing probe() to go through ?
> 
> I guess it's because some gadget drivers have USB_SPEED_SUPER as their
> max speed (?). I'll look closer into this one.

In renesas_usbhs case,
${LINUX}/drivers/usb/gadget/file_storage.c doesn't work, because of its speed.
What should I do in this case ?

Best regards
---
Kuninori Morimoto
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux