Re: [PATCH 3/5] usb: renesas_usbhs: fixup driver speed

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Nov 13, 2011 at 10:18:30PM -0800, Kuninori Morimoto wrote:
> This patch cares latest USB_SPEED_SUPER support.
> (renesas_usbhs can not use it though)
> 
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@xxxxxxxxxxx>
> ---
>  drivers/usb/renesas_usbhs/mod_gadget.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/usb/renesas_usbhs/mod_gadget.c b/drivers/usb/renesas_usbhs/mod_gadget.c
> index d9d32b2..44a6118 100644
> --- a/drivers/usb/renesas_usbhs/mod_gadget.c
> +++ b/drivers/usb/renesas_usbhs/mod_gadget.c
> @@ -755,7 +755,7 @@ static int usbhsg_gadget_start(struct usb_gadget *gadget,
>  
>  	if (!driver		||
>  	    !driver->setup	||
> -	    driver->speed != USB_SPEED_HIGH)
> +	    driver->speed < USB_SPEED_FULL)

then this patch is wrong isn't it ? If renesas_usbhs isn't
SuperSpeed-capable, why are you allowing probe() to go through ?

I guess it's because some gadget drivers have USB_SPEED_SUPER as their
max speed (?). I'll look closer into this one.

-- 
balbi

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux