Re: [RFC][PATCH 5/5] usb: gadget: udc-core: bugfix call disconnect() before unbind()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Sun, Nov 13, 2011 at 10:20:01PM -0800, Kuninori Morimoto wrote:
> disconnect() is needed before unbind()
> 
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@xxxxxxxxxxx>
> ---
> - Felipe, Greg
> 
> I'm not good at udc-core, but this patch seems needed for new style udc_start/stop.
> Please check it.
> 
>  drivers/usb/gadget/udc-core.c |    4 ++++
>  1 files changed, 4 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/usb/gadget/udc-core.c b/drivers/usb/gadget/udc-core.c
> index 022baec..350332c 100644
> --- a/drivers/usb/gadget/udc-core.c
> +++ b/drivers/usb/gadget/udc-core.c
> @@ -211,6 +211,10 @@ static void usb_gadget_remove_driver(struct usb_udc *udc)
>  
>  	if (udc_is_newstyle(udc)) {
>  		usb_gadget_disconnect(udc->gadget);
> +
> +		if (udc->driver->disconnect)
> +			udc->driver->disconnect(udc->gadget);

what's wrong with:

http://git.kernel.org/?p=linux/kernel/git/balbi/usb.git;a=commitdiff;h=4eb48e8cebbb64e2fcef9e6a26d7da9a756edb54

I even sent a pull request for that bugfix already.

-- 
balbi

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux