Re: [RFC PATCH 14/17] power_supply: Convert all users to new usb_transceiver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Fri, Aug 19, 2011 at 03:26:28PM +0300, Heikki Krogerus wrote:
> Hi,
> 
> On Fri, Aug 19, 2011 at 02:47:14PM +0300, Felipe Balbi wrote:
> > Hi,
> > 
> > On Tue, Aug 16, 2011 at 01:09:44PM +0300, Heikki Krogerus wrote:
> > > Use the new usb_transceiver_* functions instead of the old
> > > otg_* ones.
> > > 
> > > Signed-off-by: Heikki Krogerus <heikki.krogerus@xxxxxxxxxxxxxxx>
> > 
> > so until $SUBJECT is applied we have broken functionality ? Why would
> > you do that ?
> 
> In the second patch I add the aliases for the old otg_* functions. In
> this patch I simply move the users to the new function names. There is
> no broken functionality except with musb :).
> 
> I have been compiling all the drivers again and I noticed that I don't
> have a patch for musb, so musb will not work with this set. I'll send
> it in the next set.
> 
> Ideally I could convert all the drivers in one patch, and not have the
> temporary macros. But I though that it's better to let maintainers to

that would not be ideal. In fact it would be far from ideal. You would
provide one gigantic patch converting everybody and it would be really
difficult to review.

> take a look at their drivers separately at this stage.

keep it as is, don't amend everything into one big patch.

-- 
balbi

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux