-----Original Message----- From: Sebastian Andrzej Siewior [mailto:bigeasy@xxxxxxxxxxxxx] Sent: Tuesday, June 21, 2011 4:40 PM To: Mehresh Ramneek-B31383 Cc: linux-usb@xxxxxxxxxxxxxxx; gregkh@xxxxxxx; Zang Roy-R61911 Subject: Re: [RFC 1/2] fsl/usb: Add UTMI PHY support for 85xx platforms Mehresh Ramneek-B31383 wrote: >> diff --git a/drivers/usb/gadget/fsl_udc_core.c >> b/drivers/usb/gadget/fsl_udc_core.c >> index 2cd9a60..875eb75 100644 >> --- a/drivers/usb/gadget/fsl_udc_core.c >> +++ b/drivers/usb/gadget/fsl_udc_core.c >> @@ -250,6 +250,18 @@ static int dr_controller_setup(struct fsl_udc *udc) >> portctrl |= PORTSCX_PTW_16BIT; >> /* fall through */ >> case FSL_USB2_PHY_UTMI: >> +#if defined(CONFIG_FSL_SOC_BOOKE) > > Why is this BOOK-E specific? Doesn't this apply to others as well since it is the same core? > > [Ramneek]: Others (like 83xx) have different bits involved for UTMI bringup... > Below code is specific to BOOK-E socs having internal USB UTMI > phy I see. Can't you read this from OF instead of #ifdefs how the UTMI should be done? Sebastian [Ramneek]: No I cannot as different SoCs of BOOK-E family have different IP block versions -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
