-----Original Message----- From: linux-usb-owner@xxxxxxxxxxxxxxx [mailto:linux-usb-owner@xxxxxxxxxxxxxxx] On Behalf Of Sergei Shtylyov Sent: Tuesday, June 21, 2011 5:10 PM To: Mehresh Ramneek-B31383 Cc: linux-usb@xxxxxxxxxxxxxxx; gregkh@xxxxxxx Subject: Re: [RFC 2/2] fsl/usb: Add external ULPI PHY support for P101x platforms Hello. On 21-06-2011 10:12, Ramneek Mehresh wrote: > Add support for USB ULPI (external) PHY for P101x platforms > for both USB Host and Peripheral modes > Signed-off-by: Ramneek Mehresh<ramneek.mehresh@xxxxxxxxxxxxx> [...] > diff --git a/drivers/usb/host/ehci-fsl.c b/drivers/usb/host/ehci-fsl.c > index f670052..9923806 100644 > --- a/drivers/usb/host/ehci-fsl.c > +++ b/drivers/usb/host/ehci-fsl.c > @@ -226,6 +226,10 @@ static void ehci_fsl_setup_phy(struct ehci_hcd *ehci, > > switch (phy_mode) { > case FSL_USB2_PHY_ULPI: > +#if defined(CONFIG_FSL_SOC_BOOKE) > + setbits32(non_ehci + FSL_SOC_USB_CTRL, FSL_SOC_USB_CTRL | Hm, are you sure FSL_SOC_USB_CTRL should be in both these expressions? It looks like a register offset... [Ramneek]: my bad... thanks for pointing out ... will correct I also don't see 'non_ehci' variable declared in this function... [Ramneek]: 'non-ehci' variable is declared in the first RFC patch released for UTMI phys > + USB_CTRL_USB_EN | ULPI_PHY_CLK_SEL); > +#endif WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
