Hi Alan, > This patch (as1468) changes the Kconfig definition for > USB_GADGET_DUALSPEED. This option is determined entirely by which > device controller drivers are to be built, through Select statements; > it does not need to be (and should not be) configurable by the user. > > Also, the "default n" line is superfluous -- everything defaults to N. > > Signed-off-by: Alan Stern <stern@xxxxxxxxxxxxxxxxxxx> > > --- > > drivers/usb/gadget/Kconfig | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > Index: usb-2.6/drivers/usb/gadget/Kconfig > =================================================================== > --- usb-2.6.orig/drivers/usb/gadget/Kconfig > +++ usb-2.6/drivers/usb/gadget/Kconfig > @@ -597,13 +597,10 @@ config USB_DUMMY_HCD > > endchoice > > +# Selected by UDC drivers that support high-speed operation. > config USB_GADGET_DUALSPEED > bool > depends on USB_GADGET > - default n > - help > - Means that gadget drivers should include extra descriptors > - and code to handle dual-speed controllers. > > # > # USB Gadget Drivers > I was making the same change for SS and I think that if you're about to send this patch to Greg, it might need a small addition: At the moment dummy_hcd supports high_speed so I think if this option is no longer configurable by user you should set this flag when dummy_hcd is selected: config USB_DUMMY_HCD tristate depends on USB_GADGET_DUMMY_HCD default USB_GADGET select USB_GADGET_SELECTED select USB_GADGET_DUALSPEED Best regards, Tanya Brokhman Consultant for Qualcomm Innovation Center, Inc. Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
