On Wed, 25 May 2011, Alan Stern wrote: > I have looked this over more carefully. It turns out that both of you > have misunderstood the purpose of CONFIG_USB_GADGET_DUALSPEED (and by > extension, CONFIG_USB_GADGET_SUPERSPEED). In fact, the existing > Kconfig file is also wrong. > > The _only_ reason for CONFIG_USB_GADGET_DUALSPEED is so that gadget > drivers can use conditional compilation to avoid including the > high-speed descriptors when the UDC doesn't support high-speed > operation. That's all. This means that the > CONFIG_USB_GAGDET_DUALSPEED option does not need to be > user-controllable in Kconfig. It should default to N, and UDC drivers > that support high speed should select it. In other words, we should merge the following patch and the new SuperSpeed support should follow the same pattern. Alan Stern --------------------------------------------------------------------- This patch (as1468) changes the Kconfig definition for USB_GADGET_DUALSPEED. This option is determined entirely by which device controller drivers are to be built, through Select statements; it does not need to be (and should not be) configurable by the user. Also, the "default n" line is superfluous -- everything defaults to N. Signed-off-by: Alan Stern <stern@xxxxxxxxxxxxxxxxxxx> --- drivers/usb/gadget/Kconfig | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) Index: usb-2.6/drivers/usb/gadget/Kconfig =================================================================== --- usb-2.6.orig/drivers/usb/gadget/Kconfig +++ usb-2.6/drivers/usb/gadget/Kconfig @@ -597,13 +597,10 @@ config USB_DUMMY_HCD endchoice +# Selected by UDC drivers that support high-speed operation. config USB_GADGET_DUALSPEED bool depends on USB_GADGET - default n - help - Means that gadget drivers should include extra descriptors - and code to handle dual-speed controllers. # # USB Gadget Drivers -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
