On Wed, Mar 23, 2011 at 05:40, Felipe Balbi wrote:
> On Tue, Mar 22, 2011 at 02:40:07PM -0400, Mike Frysinger wrote:
>> On Mon, Dec 6, 2010 at 07:12, Felipe Balbi wrote:
>> > Felipe Balbi (30):
>> > Âusb: musb: split omap2430 to its own platform_driver
>> > Âusb: musb: split am35x to its own platform_driver
>> > Âusb: musb: split tusb6010 to its own platform_driver
>> > Âusb: musb: split davinci to its own platform_driver
>> > Âusb: musb: split da8xx to its own platform_driver
>> > Âusb: musb: split blackfin to its own platform_driver
>>
>> hmm, this doesnt seem to play well when building musb as a module
>>
>> drivers/usb/musb/Makefile:
>> obj-$(CONFIG_USB_MUSB_HDRC) += musb_hdrc.o
>> obj-$(CONFIG_USB_MUSB_BLACKFIN) Â Â Â Â += blackfin.o
>>
>> drivers/Makefile: (unrelated, but shouldnt this line be in
>> drivers/usb/Makefile?)
>> obj-$(CONFIG_USB_MUSB_HDRC) += usb/musb/
>
> You're correct. But we can't build as module now because of the
> debugging support we have on MUSB. That DBG() thingy is nice but to get
> it working we would have to re-factor the entire debugging on MUSB.
>
> That's why I recently (yesterday) sent a patch making MUSB bool until we
> get that sorted out on next merge window.
OK, i'll merge that locally then
the other thing i noticed is that musb_{read,write}_fifo cause
problems even if modules were working
(blackfin/tusb6010/tusb6010_omap). i'm guessing EXPORT_SYMBOL should
be added for both of these to the relevant files ?
-mike
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
