On Mon, Dec 6, 2010 at 07:12, Felipe Balbi wrote:
> Felipe Balbi (30):
> Âusb: musb: split omap2430 to its own platform_driver
> Âusb: musb: split am35x to its own platform_driver
> Âusb: musb: split tusb6010 to its own platform_driver
> Âusb: musb: split davinci to its own platform_driver
> Âusb: musb: split da8xx to its own platform_driver
> Âusb: musb: split blackfin to its own platform_driver
hmm, this doesnt seem to play well when building musb as a module
drivers/usb/musb/Makefile:
obj-$(CONFIG_USB_MUSB_HDRC) += musb_hdrc.o
obj-$(CONFIG_USB_MUSB_BLACKFIN) += blackfin.o
drivers/Makefile: (unrelated, but shouldnt this line be in
drivers/usb/Makefile?)
obj-$(CONFIG_USB_MUSB_HDRC) += usb/musb/
so usb/musb/ is only processed for modules. the current Kconfig setup
creates the common code as a module, but the platform-specific piece
can only be built in because it's a "choice".
drivers/usb/musb/Kconfig:
choice
prompt "Platform Glue Layer"
depends on USB_MUSB_HDRC
config USB_MUSB_BLACKFIN
bool "Blackfin"
and indeed, my resulting .config shows:
CONFIG_USB_MUSB_HDRC=m
CONFIG_USB_MUSB_BLACKFIN=y
which means when i compile, the blackfin symbols are merged into
drivers/usb/musb/built-in.o, but that isnt merged into
drivers/built-in.o, so the blackfin platform driver doesnt get a
chance to be probed.
considering the platform pieces are supposedly sep modules now, perhaps the
-mike
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
