Felipe, >-----Original Message----- >From: Felipe Balbi [mailto:balbi@xxxxxx] >Sent: Tuesday, March 22, 2011 5:01 PM >To: Hema Kalliguddi >Cc: balbi@xxxxxx; linux-usb@xxxxxxxxxxxxxxx >Subject: Re: [PATCH] usb: otg: OMAP4430: Powerdown the >internal PHY when USB is disabled > >Hi, > >On Tue, Mar 22, 2011 at 04:53:28PM +0530, Hema Kalliguddi wrote: >> >then pass NULL, you don't know the value of that dev by the >> >time you use >> >it. Either you build a real device, or pass NULL and fix >> >omap4430_phy_init() to not use dev_*() macros or you will be >> >following a >> >NULL pointer. >> >> OK. I will pass the NULL. There is no point in building the >real device >> when >> USB itself is disabled. > >BTW, the semantics of that part of the code is quite screwed up: > >we need to call omap4430_phy_init() to *power down* the PHY. > >Also, after powering down the phy, you get the clocks, that's really >screwed up. But now, can only fix that for next merge window. The intention of the omap4430_phy_init() function was to get all the clocks and default powerdown the PHY. Later in the omap4430_phy_suspend() function power on the PHY. Now that there is a requirement to powerdown the PHY when no USB is used, I am trying to use the existing function to avoid new function to export. Regards, Hema > >-- >balbi > -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
